Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(src/ru): New source: AnilibriaTV #2349

Closed
wants to merge 4 commits into from

Conversation

ToxesFoxes
Copy link

@ToxesFoxes ToxesFoxes commented Oct 10, 2023

Closes #1068
Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio

@ToxesFoxes ToxesFoxes changed the title feat(src/tr): New source: AnilibriaTV feat(src/ru): New source: AnilibriaTV Oct 10, 2023
@ToxesFoxes
Copy link
Author

ToxesFoxes commented Oct 10, 2023

I forgot to fix the main class when I transferred it to a single source, now everything works fine. Renamed some commits

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this directory and also remove all *_foreground and *_background and *_monochrome icon files.
They aren't necessary and only create issues on the website.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really necessary to include the entire API documentation?


import android.app.Application
import android.content.SharedPreferences
import android.util.Log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all logging in your final extension.

@Secozzi
Copy link
Contributor

Secozzi commented Dec 11, 2023

Closing due to inactivity, feel free to open a new pull request later with the requested changes.

@Secozzi Secozzi closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ru] Anilibria.TV
3 participants